Repository navigation
Frame generation: CPU reference of the per-call configuration - #173
Merged
Merged
Conversation
clean/fg/reference/config.py: the multi-frame intermediate time t = i / (N + 1) as one single-precision division, the index checks and the two flags, and UI recomposition (preset A / B) with the profile values that force it. The cap on N, the further mode accepting i = N + 1 and the maximum the last-index flag uses are OPEN: required arguments, listed in FORMATS.md. Refs #96 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frame-generation configuration values that are already settled, as a CPU reference (lane h). None of these values changes the networks or their weights.
clean/fg/reference/config.pyintermediate_time(n, i): the time of the generated frame, t = i / (N + 1), computed as one single-precision division (numpy float32).check_multi_frame(n, i, *, n_max, extra_index=False): N must be in 1..cap and i in 1..N. Withextra_indexset, i may also be N + 1.multi_frame_active(n)(N > 1) andlast_index(i, maximum).ui_recomposition(app_setting, profile_value)andpreset(): UI recomposition off is preset A, on is preset B. A profile value of 1 or 0xFFFFFE forces it off, 2 or 0xFFFFFF forces it on, and any other value leaves the application's setting.OPEN items are required arguments; nothing here picks them:
n_max);extra_index);maximum).The private override that can turn UI recomposition off is OPEN and not modelled.
clean/fg/FORMATS.mdhas a new "Configuration" section and OPEN item 10.Refs #96
Tested
python -m unittest clean.fg.tests.test_fg_config: 6 tests pass locally.clean/fgtest set passes. The line-ending check and the public gates pass, with no hits inclean/fg.Not tested