Skip to content

Interop tests: the Wine run's exit status counts, not only the pass marker - #172

Merged
phantoslayer21 merged 1 commit into
mainfrom
fix/interop-run-tests-status
Nov 14, 2026
Merged

phantoslayer21 merged 1 commit into
mainfrom
fix/interop-run-tests-status

Conversation

@phantoslayer21

Copy link
Copy Markdown
Owner

clean/runtime/interop/tests/run-tests.sh ended with grep -q "ALL TESTS PASSED\|^SKIP" result.txt, which threw away the Wine run's exit status. A crash after the marker counted as a pass.

Now the test program's status is kept through the output filter (PIPESTATUS inside the subshell), and the script requires both a zero exit and the marker. A SKIP (no D3D12 device) still exits 0, as the test program returns 0 there.

Checked the logic in a stand-alone simulation of the same pipeline:

program output exit result
ALL TESTS PASSED 0 pass
ALL TESTS PASSED 139 (crash) fail
SKIP: no D3D12 device 0 pass
SOME TESTS FAILED 0 fail (no marker)
SOME TESTS FAILED 1 fail

bash -n passes. Found in the re-review of #52.

Refs #52

…arker

run-tests.sh ended with a grep for the marker, which threw away the test
program's exit status: a crash after ALL TESTS PASSED counted as a pass.
Keep the program's status through the output filter and require both a zero
exit and the marker (SKIP still exits 0).

Refs #52

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
@phantoslayer21
phantoslayer21 merged commit 92d5d13 into main Nov 14, 2026
9 checks passed
@phantoslayer21
phantoslayer21 deleted the fix/interop-run-tests-status branch November 14, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant