Repository navigation
Interop tests: the Wine run's exit status counts, not only the pass marker - #172
Merged
Merged
Conversation
…arker run-tests.sh ended with a grep for the marker, which threw away the test program's exit status: a crash after ALL TESTS PASSED counted as a pass. Keep the program's status through the output filter and require both a zero exit and the marker (SKIP still exits 0). Refs #52 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean/runtime/interop/tests/run-tests.shended withgrep -q "ALL TESTS PASSED\|^SKIP" result.txt, which threw away the Wine run's exit status. A crash after the marker counted as a pass.Now the test program's status is kept through the output filter (
PIPESTATUSinside the subshell), and the script requires both a zero exit and the marker. ASKIP(no D3D12 device) still exits 0, as the test program returns 0 there.Checked the logic in a stand-alone simulation of the same pipeline:
bash -npasses. Found in the re-review of #52.Refs #52