Repository navigation
Model L on native D3D12: its own reconstruction by default (default-post check: M's post fails Model L's oracle) - #170
Merged
Conversation
…n where its route applies) Model M's fused pack12 post, the default so far, is another algorithm than Model L's (3 x 3 gather, encoded-domain history). Against Model L's post oracle on the 11 frames with the converter's real-weight Model L it fails every frame (about 76 % of the full history's FP16 values more than one ulp off); Model L's own post passes Model L's post acceptance on every frame. Record: clean/l/records/l_default_post_real_weights.json, from the new clean/l/runner/l_default_post_check.py. - runtime.cpp: without the l_post option, Model L on native D3D12 takes l_post=own where its route applies (HDR colour, the default pack12 post route, its D3D12 ports present: l_own_post_fits), else Model M's post; l_post=m and l_post=own keep their meaning (own still refuses what it cannot run). - recon.py (Model L's post oracle): motion candidate positions in float32 as the kernels compute them, as Model M's reference does since #142. In float64 one real-weight candidate position fell just past the bottom edge that the kernels' float32 arithmetic puts exactly on it (valid), which failed frame 6's reduced codes. - l_frame_check.py --compare-d3d12: follows the D3D12 run's reconstruction (Model L's own by default now: post outputs compared with HIP's byte for byte, the display image written). - Tests: the D3D12 traces of Model M's post route pass l_post=m; the default's rule is tested. Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #89
Default-post correctness check: today's default (A) fails, so this PR makes
l_post=ownModel L's default onnative D3D12. The default flip is oversight's call.
The check (offline: HIP, D3D12 runtime and CPU; no game)
clean/l/runner/l_default_post_check.py(new) runs l_frame_check's 11 frames for Model L on D3D12 in twoconfigurations and checks each post per frame against Model L's post oracle (
clean/l/reference/recon.py).model.wgcm, read by the tools only (as in Model L frame check on real weights: --model for the converter's model.wgcm; record #133):d3c040191ec7ab0164efc03ee76413277e7fb54e6e6d2b168f2c0202aa1ad806;58e6d0e7cd6926817cfea28a0b4a65c056e9bfa5ca62aa05b968b62590c9e857.values), D = 180 x 108.
over the run. Plus the rest of
l_post_rule, and the reduced codes within 1 and 99 % exact.clean/l/records/l_default_post_real_weights.json(counts and digests only).(A) Today's default, Model M's fused pack12 post (
l_post=m): FAIL.is a 4 x 4 gather with a linear-colour history mix (item 4).
(B) Model L's own post (
l_post=own): PASS.Oracle fix found on the way (in this PR).
was 4 codes off.
qy = 108exactly in the kernels' float32 arithmetic (valid), but just past 108 in the oracle's float64 (invalid),and the two samples differ widely.
recon.pynow computes the candidate positions in float32 as the kernels do (m_center's bilinear andq = X + m,Model M's
bilinear_f32). With Model M's recon entry it stays byte-identical to Model M's reference(
test_l_recon).What changes
clean/runtime/runtime.cpp: without thel_postoption, Model L on native D3D12 takesl_post=ownwhere itsroute applies (
l_own_post_fits: HDR colour, the default pack12 post route, its D3D12 ports present). Otherwise itkeeps Model M's post. LDR keeps M's post:
l_post_recon's LDR form is not written yet.l_post=mandl_post=ownkeep their meaning;ownstill refuses what it cannot run. HIP is unchanged (Model Lruns its own post there already).
clean/l/reference/recon.py: the float32 candidate positions above.clean/l/runner/l_frame_check.py --compare-d3d12: follows the D3D12 run's reconstruction. With Model L's own postby default, the post outputs are compared with HIP's byte for byte and the display image counts as written.
clean/l/runner/l_default_post_check.py(new) and the record.test_l_runtime_frame— the D3D12 traces of Model M's post route passl_post=m. The default's rule istested: own with its ports; M with
l_post=m, with HDR off, or with any own port missing.Records with the new default (GPU, gfx1201)
D3D12 Model L frame against the HIP frame (
l_frame_check --run --backend d3d12,--compare-d3d12; rawdefined bytes, sentinels; the default now runs
l_post_recon_p12):Negative controls (dropped history write, dropped reduced write, whole reduced write, missing output): all caught.
HIP against the references (
l_frame_check --compare, every stage):Synthetic oracle check (
l_post_check.py --seeds 6, new oracle): pass, 6 of 431784 values more than 1 ulp off,negative control caught.
CPU tests:
test_l_runtime_frame20 OK,test_l_recon15 OK,test_l_reference18 OK,test_l_pack13 OK,test_l_map3 OK.Gates: leak scan 0 hits; public gates at the baseline (31 / 18 / 108).
Tested / Not tested
not written).