Repository navigation
Model L in games: the D3D12 executor and the L model path on every executor - #152
Merged
Merged
Conversation
… Model L goes to the D3D12 executor Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
…ared configure checked Model M's) Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
…y executor); CPU test test_model_path.py Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #89
Two faults that kept Model L (model=L) from running in a game on native D3D12, found in the first Cyberpunk 2077 runs
with #140:
interop/backend.cpp): the executor request setmodel_kfor every model other than M, somodel=L took the "model K has no D3D12 port; the HIP executor runs it" route. Now only model K takes that route;
Model L goes to the D3D12 executor (the native D3D12 frame of Model L frame on native D3D12: Model M's native frame with Model L's encoder and decoder #140). Model M and model K are unchanged.
interop/backend.cppconfigure_hip, the configure step both executors share): with model=Lit still required Model M's file (
<model_dir>\model.wgcm) and refused with "no converted model at ...". Newmodel_wgcm_pathinmodel_select.hgives each model's file from the model table: Model M<model_dir>\model.wgcm(unchanged), Model L<model_dir>\L\model.wgcm, used by the configure step.Test:
clean/runtime/interop/tests/test_model_path.py(CPU, run by the Python test set) buildsmodel_path_check.cppand checks model=L -><model_dir>\L\model.wgcm, model=M unchanged, model=K's folder, and thatthe option
model=Lresolves to Model L.Tested:
Ran 1 test ... OK).model-l/ingameadea429, with Model L frame on native D3D12: Model M's native frame with Model L's encoder and decoder #140 and the Model L buildswitch): Cyberpunk 2077 and Resident Evil Requiem ran Model L on the D3D12 executor at 1280x720 -> 1920x1080. The
runtime's launch trace showed every Model L kernel (
lev/input_encoder_direct,l_swin_block_c32_enc_nc/_dec_nc,l_coef_pack12, ...) once per frame, with 0 failed dispatches. Records and screenshots are kept with therelease lead's run notes.
Not in this PR: the Model L build switch (
--model-l) and thelaunch_traceruntime option used for that evidence;they follow separately.