Repository navigation
D3D12: analytic-filter direct forms of the fused output kernels, checked against HIP through a direct frame - #146
Merged
Conversation
…), byte for byte against HIP post.hlsl WG_LZ_ANALYTIC: w64/post_tf_f32_p12_diet_vsit and w64/post_tf4_dl_f32_p12_diet_vsit of post_w64.co (the build the runtime loads when the model file has no output-filter weights, e.g. Model L): FP32 Lanczos constants, FP32 values between the passes, no weight arguments. The original's DXILs are unchanged. post_tf_d3d12_check.py: these ports against HIP post_w64.co with l_d3d12_ops_check.py's engine (raw bytes, sentinels, slack, negative control), the original port against post_w64__orig.co as the Model M control; the harness takes a kinds table and a HIP block. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
…ked against HIP through a direct frame post.hlsl: w64/post_tf_f32_p12_diet_vsit_direct and w64/post_tf4_dl_f32_p12_diet_vsit_direct of post_w64.co (WG_LZ_ANALYTIC with POST_OUT 3): the analytic filter in the direct form's vertical item, without the FP16-indexed output table. The original's DXILs are unchanged. kernel_replay.cpp: a direct line (bind_direct_frame with RGBA32F colour and output textures, the output read back). post_tf_d3d12_check.py --direct: the direct ports' output texels, history and reduced codes against HIP's form 0 (post_w64.co), the original's direct port against post_w64__orig.co as the control. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com> # Conflicts: # clean/dx12/tests/kernel_replay.cpp
…ed build) The analytic-filter ports declare the same kernel names as the original filter's with co=post_w64.co; every declaration line is still checked for the 256 lanes and the cap. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
phantoslayer21
marked this pull request as ready for review
November 14, 2026 04:44
phantoslayer21
added a commit
that referenced
this pull request
Nov 14, 2026
…well The direct-resource route required the "original" output-filter build of the wave64 fused post (post_w64__orig.co) with the model file's filter weights. With the analytic-filter ports on main (#145, #146; keyed by name and code object, #143) it also takes post_w64.co, the build a model file without those weights uses, as Model L's: the check now refuses only quality5 / quality9, a post outside wave64, or the original filter without weights. test_l_runtime_frame.py: the D3D12 tests use the declared ports as they are (both filter builds of Model M's fused post are declared now); a test that the analytic build of the fused pack12 post is among them. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
phantoslayer21
added a commit
that referenced
this pull request
Nov 14, 2026
…well The direct-resource route required the "original" output-filter build of the wave64 fused post (post_w64__orig.co) with the model file's filter weights. With the analytic-filter ports on main (#145, #146; keyed by name and code object, #143) it also takes post_w64.co, the build a model file without those weights uses, as Model L's: the check now refuses only quality5 / quality9, a post outside wave64, or the original filter without weights. test_l_runtime_frame.py: the D3D12 tests use the declared ports as they are (both filter builds of Model M's fused post are declared now); a test that the analytic build of the fused pack12 post is among them. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
phantoslayer21
added a commit
that referenced
this pull request
Nov 14, 2026
…well The direct-resource route required the "original" output-filter build of the wave64 fused post (post_w64__orig.co) with the model file's filter weights. With the analytic-filter ports on main (#145, #146; keyed by name and code object, #143) it also takes post_w64.co, the build a model file without those weights uses, as Model L's: the check now refuses only quality5 / quality9, a post outside wave64, or the original filter without weights. test_l_runtime_frame.py: the D3D12 tests use the declared ports as they are (both filter builds of Model M's fused post are declared now); a test that the analytic build of the fused pack12 post is among them. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #89
Stacked on #145 (analytic-filter buffer forms; #143 has merged); this PR adds its own commit on top.
The game route on native D3D12 runs the
_directforms of the fused output kernels: the colour is read from the game's texture and the output is written into its texture. This PR adds the analytic-filter (post_w64.co) direct forms and a way to check them against HIP.What
clean/dx12/kernels/post.hlsl:w64/post_tf_f32_p12_diet_vsit_directandw64/post_tf4_dl_f32_p12_diet_vsit_directwithco=post_w64.co(WG_LZ_ANALYTICwithPOST_OUT = 3).clean/dx12/tests/kernel_replay.cpp: adirect_out <file>case line next to Model L: D3D12 direct form of the halo input encoder (lev/input_encoder_direct), byte for byte against its HIP twin #144'sdirect/direct_paramslines. After the launch, the output texture is read back (rows packed). The harness gives an RGBA32F colour texture with the colour buffer's values, depth and motion of zeros, and an RGBA32F output filled with a sentinel word, at color_pi 1 with no exposure texture.clean/dx12/tests/post_tf_d3d12_check.py --direct: the direct forms have no HIP kernel of their own; post.hlsl defines form 3 as form 0 followed by the output store. With color_pi 1 and RGBA32F textures, a direct port's output must match HIP's form 0 (post_w64.co) as follows:l_d3d12_ops_check.py(raw bytes, sentinels, slack);out_pbuffer stays untouched.GPU record
post_tf_d3d12_check.py --run --direct --seeds 3, one GPU slot, this branch's DXILs andkernel_replay.exe.w64/post_tf_f32_p12_diet_vsit_direct(analytic) vs HIPpost_tf_f32_p12_diet_vsit(post_w64.co)w64/post_tf4_dl_f32_p12_diet_vsit_direct(analytic) vs HIPpost_tf_f32_p12_diet_vsit/post_tf_dl_f32_p12w64/post_tf_f32_p12_diet_vsit_direct(original) vspost_w64__orig.coform 0out_puntouched in every case; alpha 1.0 everywhere.w64_post_tf_f32_p12_diet_vsit_direct_s0_4again with half its workgroups. Caught: 829,440 texture words differ.post.hlsl, built from main and from this branch: SHA-256 identical, 10 of 10 (w64/post_tf_*incl._tex,_direct, tf4;pmo/post_tf*_mo*). A manifest of this branch holds them unchanged plus four analytic entries.Tested
Not tested
output_rne16); typed output formats other than RGBA32F.