Repository navigation
Model L: D3D12 ports of the two projections, byte for byte against their HIP kernels - #123
Merged
Merged
Conversation
…eir HIP kernels l_ops_project.hlsl ports l_project_gather and l_dec_project of l_ops.co (clean/l/kernels/l_ops.hip, #115): two FP8 WMMAs then RN16 per group of 32 inputs, the gather's clamp, FP8 out; no branch (a lane past the last token stores its clamped token's bytes to that token's place). l_d3d12_ops_check.py gains their cases (6 token grids, two of them partly filled waves). Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
phantoslayer21
marked this pull request as ready for review
November 14, 2026 01:42
Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model L (#89): the D3D12 ports of Model L's two projections, byte for byte against their HIP kernels:
l_project_gather(the encoder's output projection) andl_dec_project(the decoder's input projection) ofl_ops.co(
clean/l/kernels/l_ops.hip).Stacked on #122 (input linears; it adds this group's cases to #122's harness). Depends on #115 for the HIP
kernels it is checked against (checked at #115's head 0ec574e). CI needs neither: nothing here runs without a GPU.
clean/dx12/kernels/l_ops_project.hlsl(new): both kernels from one source (PJ_DEC).clean/l/FORMATS.md); each tile's loads before its first matrixinstruction;
HIP) and stores that token's bytes to that token's place.
clean/l/runner/l_d3d12_ops_check.py: the projections' cases. Six token grids: 8 x 12, 18 x 34, 4 x 4, 34 x 50,and 3 x 5 and 2 x 9, which are partly filled waves.
Refs #89
Tested
Local, Windows, Radeon RX 9000 series card, with #115's HIP kernels:
l_d3d12_ops_check.py --run --seeds 6 --kernels l_project_gather,l_dec_project:l_project_gather: 36 of 36 cases identical (6 seeds x 6 grids; 943,488 output bytes);l_dec_project: 36 of 36 identical (1,886,976 bytes);swin_block_c96_nc: 36 of 36 identical (3,167,424 bytes);(HIP 0xA5, D3D12 0x5A).
build_dx12.py --isa:l_project_gather4buffer_store, 32v_wmma;l_dec_project8buffer_store, 32v_wmma; 0 branches (the stores the kernels must issue).python tools/ci/check_line_endings.py: 0 problems. Public gates (secrets, personal data, licence, chunks) pass.Not tested
max / min).