Repository navigation
Model L tensor list: the confirmed layout (fixes test_l_runtime_load on main) - #112
Merged
Merged
Conversation
…e_load on main #110 merged after #109 changed the structure table: the runtime's Model L tensor list still had the earlier layout and its test called table.encoder_shapes, which #109 removed. Now the map's stages (enc0, enc0_block, the ten shared stages, dec0_block, dec0, post), names and shapes; the test checks them against data/preset-L.v1.map.json and table.param_shapes. Refs #89 Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
This was referenced Nov 13, 2026
phantoslayer21
marked this pull request as ready for review
November 14, 2026 00:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a break on main from the merge order of #109 and #110. #110 (the runtime's Model L tensor list) was tested
before #109 settled the structure table. When it merged after #109, its test still called
table.encoder_shapes,which #109 removed, and its tensor list had the earlier layout.
clean/l/runtime/tests/test_l_runtime_load.pyfailson main (3 errors). Nothing changes for Model M.
What changes
clean/l/runtime/l_model.h/.cpp: Model L's stages in the preset-L map's order, with its names and shapes:Win1/bin132 x 20,Win2/bin232 x 32;enc0_block: the width-32 block;dec0_block;test_l_runtime_load.py: the list is checked againstdata/preset-L.v1.map.json(stages, names, shapes, types, inorder) and against
table.param_shapes; the refusal case usesdec0_block/W1.bin.Refs #89
Tested
test_l_runtime_load.py: 5 tests, OK (MSVC and clang++). On main before this change: 3 errors(
table.encoder_shapesmissing,KeyError: 'Wa').clean.l.tests.test_l_pack,test_l_reference,clean.tests.test_model_pack_cpp,test_model_select,test_model_filter,test_model_tables: 63 tests, OK.Not tested