Skip to content

Model L tensor list: the confirmed layout (fixes test_l_runtime_load on main) - #112

Merged
phantoslayer21 merged 1 commit into
mainfrom
model-l/l-tensors-confirmed
Nov 14, 2026
Merged

phantoslayer21 merged 1 commit into
mainfrom
model-l/l-tensors-confirmed

Conversation

@phantoslayer21

Copy link
Copy Markdown
Owner

Fixes a break on main from the merge order of #109 and #110. #110 (the runtime's Model L tensor list) was tested
before #109 settled the structure table. When it merged after #109, its test still called table.encoder_shapes,
which #109 removed, and its tensor list had the earlier layout. clean/l/runtime/tests/test_l_runtime_load.py fails
on main (3 errors). Nothing changes for Model M.

What changes

  • clean/l/runtime/l_model.h/.cpp: Model L's stages in the preset-L map's order, with its names and shapes:
    • enc0: W 64 x 128, b, T, sigma1, sigma2, Win1/bin1 32 x 20, Win2/bin2 32 x 32;
    • enc0_block: the width-32 block;
    • the ten shared stages (Model M's);
    • dec0_block;
    • dec0: W 4 x 32 x 64, b 4 x 32, S, T;
    • post.
  • test_l_runtime_load.py: the list is checked against data/preset-L.v1.map.json (stages, names, shapes, types, in
    order) and against table.param_shapes; the refusal case uses dec0_block/W1.bin.

Refs #89

Tested

  • test_l_runtime_load.py: 5 tests, OK (MSVC and clang++). On main before this change: 3 errors
    (table.encoder_shapes missing, KeyError: 'Wa').
  • With clang++: clean.l.tests.test_l_pack, test_l_reference, clean.tests.test_model_pack_cpp,
    test_model_select, test_model_filter, test_model_tables: 63 tests, OK.

Not tested

  • No GPU run (loading only; no frame uses it on main).

…e_load on main

#110 merged after #109 changed the structure table: the runtime's Model L tensor list still had the earlier layout and its test called table.encoder_shapes, which #109 removed. Now the map's stages (enc0, enc0_block, the ten shared stages, dec0_block, dec0, post), names and shapes; the test checks them against data/preset-L.v1.map.json and table.param_shapes.

Refs #89

Signed-off-by: phantoslayer21 <156617979+phantoslayer21@users.noreply.github.com>
@phantoslayer21
phantoslayer21 marked this pull request as ready for review November 14, 2026 00:01
@phantoslayer21
phantoslayer21 merged commit 2085f40 into main Nov 14, 2026
2 checks passed
@phantoslayer21
phantoslayer21 deleted the model-l/l-tensors-confirmed branch November 14, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant