Skip to content

Launcher refuses vkd3d-proton next to a game under Proton, where it is the game's Direct3D 12 #50

Open

Description

@j0nsh1n

What happens

The coexistence check refuses a game with vkd3d-proton (or DXVK) in its folder. That's right on Windows, where it would replace Windows' Direct3D 12.

Under Proton, vkd3d-proton is the game's Direct3D 12. Until a Proton release ships dxil-spirv PR #362, a self-built vkd3d-proton placed next to the game exe is the only way Model M and RR run on Linux. Proton loads d3d12/d3d12core as native, so the game picks those two DLLs from its folder. So today the launcher refuses exactly the setup Linux players need.

Suggested change (a policy choice, so yours to make)

Under Wine only, report vkd3d-proton next to the game as a note instead of a refusal. Keep refusing DXVK, and keep refusing vkd3d-proton on Windows.

// wg_core/coexist.cpp, in the DXVK / vkd3d-proton rule
if (!f.empty() && t == Tool::Vkd3d && UnderWine())
    add(t, Decision::Inform, wstring(ToolName(t)) + L" as " + f[0], f, fpOf(t)->evidence,
        L"Under Wine (Proton) vkd3d-proton is the game's Direct3D 12. Left alone; Model M needs a vkd3d-proton whose "
        L"dxil-spirv has pull request #362 (AMD's matrix instructions as WrongGPU uses them).");
else if (!f.empty())
    add(t, Decision::Refuse, ...);   // unchanged

How it was tested

  • coexist-core-tests with a synthetic game fixture: Game.exe plus a d3d12.dll that contains a vkd3d-proton marker string.
    • Under GE-Proton 11-11's Wine it expects Inform; outside Wine it expects Refuse.
    • The check failed with the Wine branch taken out.
  • A launcher install into a generated test game with vkd3d-proton next to it went through under proton run.
  • Not run on Windows.

The change with its tests is in PR #105: commit 1afe78b, which needs only 677af52 (UnderWine()).

Related: #10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    • Status
      Todo

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions