Skip to content

Launcher under Wine/Proton writes model paths the game's own prefix can't reach (C: instead of Z:) #49

Open

Description

@j0nsh1n

What happens

On Linux, players run the launcher under Wine, while Steam's Proton runs each game in a Wine prefix of its own. The launcher writes two paths into the game's settings:

  • model_dir (wronggpu.ini);
  • rr_model (wronggpu-rr.ini).

Both are written as C:\users\<user>\AppData\Local\WrongGPU\model... paths of the launcher's own prefix. The game's prefix has a different C:, so Model M and Ray Reconstruction find no model there.

Suggested fix

Under Wine, write those two paths as Z: paths: Z: maps the Linux root in every prefix, so the game reaches the same files.

  • Wine's kernel32 exports wine_get_unix_file_name, which gives the Linux name of a DOS path.
  • It fails when more than the last part of the path doesn't exist yet (the RR data's F\ folder before its first conversion). So convert the deepest folder that exists and append the rest.
  • A model_dir the player set stays as it is.
  • Detecting Wine: GetProcAddress(GetModuleHandleW(L"ntdll.dll"), "wine_get_version") != nullptr.

The core of it, as I tested it (wg_core/util.cpp):

wstring PathForGamePrefix(const wstring& path) {
    if (path.empty() || !UnderWine()) return path;
    using UnixNameFn = char*(CDECL*)(const wchar_t*);
    auto unixName = reinterpret_cast<UnixNameFn>(reinterpret_cast<void*>(
        GetProcAddress(GetModuleHandleW(L"kernel32.dll"), "wine_get_unix_file_name")));
    if (!unixName) return path;
    wstring head = path, tail;
    char* u = nullptr;
    while (!(u = unixName(head.c_str()))) {          // missing folders: walk up, keep the tail
        const size_t cut = head.find_last_of(L"\\/");
        if (cut == wstring::npos || cut < 3) return path;
        tail = head.substr(cut) + tail;
        head.resize(cut);
    }
    wstring z = L"Z:" + FromUtf8(u) + tail;
    HeapFree(GetProcessHeap(), 0, u);                  // Wine allocates it on the process heap
    for (wchar_t& c : z) if (c == L'/') c = L'\\';
    return z;
}

install.cpp then writes model_dir = PathForGamePrefix(ModelBaseDir()) under Wine when the player set none, and RrIniText(PathForGamePrefix(RrDataFile())). Outside Wine nothing changes: the function returns the path unchanged.

How it was tested (synthetic data only)

  • wg_core_tests under GE-Proton 11-11's Wine (llvm-mingw build): the path names the same file, and a path with two missing folders still becomes a Z: path with its tail kept. Outside Wine the path is unchanged. The missing-folder check failed with the walk-up taken out.
  • Launcher installs into generated test games, started with proton run on a new empty prefix under GE-Proton 11-11, Proton 11.0 and Proton-CachyOS, wrote model_dir=Z:\... and rr_model=Z:\...\F\model.wgcm.
  • Not run on Windows.

The change with its tests is in PR #105: commit 1b024cf, which needs only 677af52 (UnderWine()).

Related: #10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    • Status
      Todo

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions