Skip to content

Linux emulator tests have not passed since 0.6.0 (CI runs them only on Windows, where they skip) #277

Open

Description

@j0nsh1n

On Ubuntu 24.04 with clang 18 (and clang 22, AMD clang 24 locally), python -m unittest clean.tests.test_post_emu fails with
emulator build failed: clean/kernels/swin.hip:486: use of undeclared identifier '__builtin_amdgcn_readfirstlane' and swin.hip:504: invalid output constraint '+s' in asm. The host build already has wg_uniform (wg_platform.h), and the asm needs an #ifndef WG_EMU
guard. Four more tests are stale or broken on Linux:
test_model_wgcm links the converter without lz4block.cpp, convert5.cpp, ops5.cpp, api.cpp;
test_post_emu compares post_filter_quality9 (Lanczos-3) with the default filter's reference;
check_no_dev_diagnostics.py uses os.path.basename on the packager's backslash paths, so dx12\manifest.json is never checked on Linux
(5 test_unchecked_d3d12_kernels_refuse_the_payload subtests fail);
test_runtime_external / test_runtime compare RGBA16F output with a plain astype(np.float16) (inf) while the kernels saturate to 65504.
g++ cannot build the emulator at all (ext_vector_type), although test_kernels_emu.py falls back to it.
CI runs the Python tests on windows-2022. The emulator tests (test_post_emu, test_runtime, test_runtime_external, and test_model_wgcm, which builds the converter with a Linux toolchain) skip there. test_dev_diagnostics_off is not skipped and passes on Windows, because Windows path handling recognises backslashes; its Linux failures are only the path-separator bug. So the Linux failures are invisible to CI. A Linux shard would catch them.
A PR with the five fixes follows (each applies to main on its own; the gfx1201 HIP objects are byte-identical before and after).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions