Skip to content

Launcher tests: "uninstall.exe is the small restorer" uses a size ratio that depends on the payload and toolchain #234

Open

Description

@phantoslayer21

The launcher suite check "uninstall.exe is the small restorer, not the launcher"
(clean/installer/tests/run_launcher_tests.py, around line 328) passes only if the uninstaller written into the game is
smaller than a quarter of the launcher. With the suite's small test payload and an MSVC build (static C runtime), the
restorer is about a third of the launcher (about 4.1 MB vs 11.8 MB), so the check fails although the right program
(the embedded restorer, not a copy of the launcher) was written. The ratio depends on how big the payload is and on
the toolchain, not on the uninstall logic.

Fix: identify the restorer directly instead of by size. For example compare the written uninstaller with the embedded
restorer's bytes or version resource, or compare against the launcher's size minus its payload, or use a fixed upper
bound for the restorer. Keep a check that a copy of the full launcher would fail.

Found while working on #224 (launcher uninstall checks, #219); not part of that fix.

Activity

  1. added this to the 0.6.5 milestone on Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingbuildBuilding from source

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions