Skip to content

Launcher suite: two uninstall checks fail on main (RR settings after an in-game edit, RE9 mirror) #219

Open

Description

@j0nsh1n

Two checks of tests/run_launcher_tests.py fail on main (9ef4da7). Found while merging main into the native Linux launcher branch; both reproduce the same way with main's own launcher (MinGW WRONGGPU_TESTING build, -DWRONGGPU_PRESET_K=OFF) under Wine (GE-Proton 11-11). Not run on Windows, so it is possible the checks rather than the code are out of date.

1. test_rr: "uninstall: exit 0, the RR game's folder as before except the two RR settings files the plugin rewrote..."

After the suite edits WrongGPU\wronggpu.ini as the plugin would (rr_mode = fast, rr_overlay=1), the next repair records that file as the player's: its record line goes from copy 0 - <inst> to copy 1 <sha of the edited file> <inst> ("Backed up and replaced"). The final uninstall then says it is "partly" done (WrongGPU\wronggpu.ini is now another setup's OptiScaler) and leaves WrongGPU-originals\<stamp>\WrongGPU\wronggpu.ini behind, which the check does not expect.

2. test_re9: "uninstall after the update: everything of WrongGPU's gone from the folder and the mirror; the player's mirrored file stays"

_storage_\dxgi.dll (sha256 6c66d3d8...) is left after the update and uninstall.

Also

  • The WrongGPU target no longer builds with llvm-mingw 20261104: WICBitmapInterpolationModeHighQualityCubic, D2D1_GAUSSIANBLUR_OPTIMIZATION_QUALITY, UIA_ScrollPatternNoScroll and the __uuidof of two UI Automation interfaces are missing from its headers. clean/linux/run_wine_tests.py builds only the unit tests, so it does not catch this. MinGW is for testing only, so this may not matter to you.
  • --only re9 fails at the call: main() passes synth_f only to rr.

Activity

  1. added this to the 0.6.5 milestone on Nov 15, 2026
  2. phantoslayer21 commented on Nov 15, 2026

    @phantoslayer21
    Owner

    Taking this into 0.6.5. Both uninstall checks get run on Windows first, to tell whether the code or the checks are out of date. If either reproduces there it blocks the release: uninstall must leave nothing of WrongGPU's behind.

    The llvm-mingw header gaps and the --only re9 call are noted too; those come after the two uninstall cases.

  3. j0nsh1n commented on Nov 15, 2026

    @j0nsh1n
    ContributorAuthor

    Correction: the two uninstall checks are out of date, not the launcher. Both follow 0.6.1's file-ownership rule as the README describes it (a file whose bytes aren't the recorded ones stays; an original that can't go back is kept in WrongGPU-originals; an unrecorded mirror copy is the player's). #222 updates the two checks; the MinGW build and --only re9 parts follow in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions