You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Launcher: Engine.ini selective restore can lose a replacement made after it was read #186
On uninstall, the selective Engine.ini restore (clean/installer/src/wg_core/rrconfig.cpp:354-381, called from record.cpp:799) reads the player's Engine.ini and computes what to remove. Another program can replace the file after that read, before ForceDelete or WriteFileAtomic, and the replacement is lost. Restoring an absent file has the same problem: it writes with replace after an existence check.
Expected: compare and write the same file through one handle, and create a missing file without replacing anything that appeared meanwhile. Whether WrongGPU should edit a player's configuration selectively at all is a separate ownership question, to be settled in this issue.
Activity
Launcher: review fixes for roll back and the Engine.ini revert
Launcher: Engine.ini revert re-check fixes (corrected copy verified a…
Launcher: Engine.ini revert never writes into the live file after the…
Launcher: roll back and the Engine.ini revert change only WrongGPU's …