Skip to content

Launcher: Engine.ini selective restore can lose a replacement made after it was read #186

Closed

Description

@phantoslayer21

On uninstall, the selective Engine.ini restore (clean/installer/src/wg_core/rrconfig.cpp:354-381, called from record.cpp:799) reads the player's Engine.ini and computes what to remove. Another program can replace the file after that read, before ForceDelete or WriteFileAtomic, and the replacement is lost. Restoring an absent file has the same problem: it writes with replace after an existence check.

Expected: compare and write the same file through one handle, and create a missing file without replacing anything that appeared meanwhile. Whether WrongGPU should edit a player's configuration selectively at all is a separate ownership question, to be settled in this issue.

Found in the review of #47.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: launcherLauncher and installerarea: ray-reconstructionRay Reconstruction runtime, plugin and kernelsbugSomething isn't working

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions