Skip to content

Launcher: install, repair and update can delete or overwrite a file replaced after the backup #185

Open

Description

@phantoslayer21

Install, repair and update (clean/installer/src/wg_core/install.cpp:788-838, util.cpp:120-149) hash and verify a backup, then act on the target by path: they delete a disable target, delete a rename destination, and write payloads with MOVEFILE_REPLACE_EXISTING or CopyFileW(..., FALSE).

If another program replaces the target after the backup, or creates a target that was absent, the new file is deleted or overwritten while the backup holds the old bytes. This also covers repair and update after a restore, and the FSR rename-aside.

Expected: hold and verify the destination through the action (one handle), or create with fail-if-present, so a replacement is detected and kept. Needs race tests across the whole operation.

Found in the review of #47.

Activity

  1. added this to the 0.6.1 milestone on Nov 14, 2026
  2. modified the milestones: 0.6.5, 0.6.6 on Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: launcherLauncher and installerbugSomething isn't working

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions