You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Model M reconstruction: zero total gather weight differs between the reference and the confirmed behaviour #129
While settling Model L's reconstruction reference (#124) the behaviour for a gather whose total weight is exactly zero (extreme but finite coefficients, every tap underflows) was confirmed for both models: there is no special path, the NaN propagates, and the decode passes NaN through.
Model M's CPU reference (clean/reference/post.py, dec) instead maps a NaN to the low clamp value, so for this input the Model M reference and the confirmed behaviour give different history values.
To do:
state what Model M's D3D12 and HIP reconstruction kernels produce for this input (a synthetic case with zero total weight);
bring the reference, and if needed the kernels, to the confirmed behaviour, with a known-answer test as in Model L's test_l_recon.py.
This needs extreme coefficient values; no visible effect in a game has been reported. Refs #89
Activity