Consolidate vmp/svp traits, improve CRT^-1 by ~x2#135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poulpy-halVmpApplyDftToDftAddandSvpApplyDftToDftAddtraits; merge additive variant intoVmpApplyDftToDft/SvpApplyDftToDftvia a newlimb_offsetparameter.These traits accumulated VMP results directly into a scattered output buffer, causing severe cache misses. Writing into a contiguous temporary buffer and folding with
VecZnxDftAddInplaceis ~2× faster.VmpApplyDftToDftAddImpl,VmpApplyDftToDftAddTmpBytesImpl,SvpApplyDftToDftAddImpl), delegate, and bench-suite plumbing.poulpy-cpu-ref/poulpy-cpu-avxvmp_apply_dft_to_dftimplementations to acceptlimb_offsetdirectly, replacing the separate_addcodepath.arithmetic_avx.rs): addreduce_b_and_apply_crtthat fuses the CRT multiply into the Barrett reduction pass, using new compile-time constantsPOW32_CRTandPOW16_CRT; apply tocompact_all_blocksto reduce instruction count by a factor of ~2x.poulpy-coreglwe_external_product_internal) and GLWE keyswitching inner loops to write intermediate per-digit VMP results into a dedicated temporary buffer before accumulating withVecZnxDftAddInplace, avoiding scattered-write cache thrashing.wherebounds updated accordingly.bench_suite::keyswitch::gglwemodule andkeyswitch_glwecriterion benchmark targeting the NTT120 backend; remove the old FFT64-specifickeyswitch_glwe_fft64benchmark.