Handle TimeoutError when waiting for the writer to close #342
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to fix #202. As the issue indicates, the error is:
This happens because
asynciosets a timeout on the close. If the client is idle, then when the timeout period is reached it raises the error above. This patch fixes that by addingTimeoutErrorto the list of exceptions caught when callingself.writer.wait_closed; it also tries to abort the transport to clean up resources. I tested withasyncioand withuvloop, where the transport classes areasyncio.sslproto._SSLProtocolTransportanduvloop.loop._SSLProtocolTransportrespectively.I am submitting this PR as an individual contributor under the existing Hypercorn MIT license.