-
Notifications
You must be signed in to change notification settings - Fork 15
fix: improve type safety for skip-cascade mode in flow steps #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 01-09-pgf-3hs.14_add_condition_fields_to_flowshape_for_auto-compilation
Are you sure you want to change the base?
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 44482fc
☁️ Nx Cloud last updated this comment at |
464dab0 to
44482fc
Compare

Improved Type Safety for Skip-Cascade Dependencies
This PR fixes a type safety issue with the
skip-cascademode in our Flow DSL. Previously, dependencies withwhenUnmet: 'skip-cascade'orretriesExhausted: 'skip-cascade'were incorrectly marked as optional for dependent steps.The key insight is that with
skip-cascade, if a step is skipped, its dependents are also skipped at runtime. This means that if a dependent handler runs at all, the parent step must have succeeded, and therefore the dependency should be required, not optional.Changes:
skippableflag with a more preciseSkippableModetype ('skip'|'skip-cascade'|false)'skip'(not'skip-cascade')This change improves type safety by preventing unnecessary null checks for dependencies that are guaranteed to exist when using
skip-cascade.