Independent object counting from GC#4
Draft
pf0n wants to merge 10 commits intotest/shen-aggregate-closurefrom
Draft
Independent object counting from GC#4pf0n wants to merge 10 commits intotest/shen-aggregate-closurefrom
pf0n wants to merge 10 commits intotest/shen-aggregate-closurefrom
Conversation
ysramakrishna
suggested changes
Aug 15, 2025
ysramakrishna
left a comment
ysramakrishna
left a comment
There was a problem hiding this comment.
Looks mostly good.
Left a few comments.
Sorry for the delay in getting to this.
| "0 will allow back to back young collections to run during old " \ | ||
| "collections.") \ | ||
| \ | ||
| product(uintx, ShenandoahObjectCountInterval, 0, \ |
There was a problem hiding this comment.
"JFR" somewhere in the name so it's clear.
I wouldn't use "0" to mean disabled, since the enabling or disabling is controlled separately by whether the event is enabled or disabled.
In any case, I suppose your plan is to get this value from the JFR event in the future, so may be this semantics can be ignored (i.e. kept) for now. I wouldn't spend time on it.
| * & vm.opt.ExplicitGCInvokesConcurrent != false | ||
| * @library /test/lib /test/jdk | ||
| * @run main/othervm -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:+ExplicitGCInvokesConcurrent -XX:MarkSweepDeadRatio=0 -XX:-UseCompressedOops -XX:-UseCompressedClassPointers -XX:+IgnoreUnrecognizedVMOptions jdk.jfr.event.gc.objectcount.TestObjectCountEventWithShenandoah | ||
| * @run main/othervm -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:ShenandoahObjectCountInterval=300 -XX:+ExplicitGCInvokesConcurrent -XX:MarkSweepDeadRatio=0 -XX:-UseCompressedOops -XX:-UseCompressedClassPointers -XX:+IgnoreUnrecognizedVMOptions jdk.jfr.event.gc.objectcount.TestObjectCountEventWithShenandoah |
There was a problem hiding this comment.
In order to get these events, you might need to sleep for a sufficient period of time so that the (non-gc) object count event is produced.
…ntGC, and redefined final mark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.