This repository was archived by the owner on Jun 19, 2023. It is now read-only.
Fix "[: -eq: unexpected operator" message#318
Closed
asheiduk wants to merge 2 commits intopetervanderdoes:developfrom
Closed
Fix "[: -eq: unexpected operator" message#318asheiduk wants to merge 2 commits intopetervanderdoes:developfrom
asheiduk wants to merge 2 commits intopetervanderdoes:developfrom
Conversation
If the first DEFINE is not DEFINE_boolean the shell prints an error message.
Using the example in the header of gitflow-shFlags:
./hello.sh: 359: [: -eq: unexpected operator
Hello, world.
This is triggered by
if [ ${_flags_type_} -eq ${__FLAGS_TYPE_BOOLEAN} \
-a ${_flags_isNegate_} -eq ${FLAGS_TRUE} ]; then
where `_flags_isNegate_` is not set and hence the shell reads `-a -eq 0`
This is masked because by the first DEFINE_boolean because `_flags_define`
does not unset the internal variable `_flags_isNegate_` at the end and hence
the value spills over to the next invocation.
Currently all commands seems to define a boolean option first, so strictly
speaking gitflow is not affected.
Signed-off-by: Andreas Heiduk <asheiduk@gmail.com>
Contributor
Author
|
@petervanderdoes |
Signed-off-by: Andreas Heiduk <asheiduk@gmail.com>
Owner
|
Thank you for your contribution. Set to be merged for the next release, available since 3b4740c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the first DEFINE is not DEFINE_boolean the shell prints an error message.
Using the example in the header of gitflow-shFlags:
./hello.sh: 359: [: -eq: unexpected operator
Hello, world.
This is triggered by
where
_flags_isNegate_is not set and hence the shell reads-a -eq 0This is masked because by the first DEFINE_boolean because
_flags_definedoes not unset the internal variable
_flags_isNegate_at the end and hencethe value spills over to the next invocation.
Currently all commands seems to define a boolean option first, so strictly
speaking gitflow is not affected.
Signed-off-by: Andreas Heiduk asheiduk@gmail.com