Repository navigation
Verify the final Year View release ZIP - #13
Open
peterjthomson wants to merge 4 commits into
Open
peterjthomson wants to merge 4 commits into
peterjthomson wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 70d0d73. Configure here.
| run('xattr', '-w', 'com.apple.quarantine', '0081;00000000;ReleaseVerification;', str(copied)) | ||
| run('spctl', '--assess', '--type', 'open', '--context', 'context:primary-signature', str(copied)) | ||
| mount = work / 'mount' | ||
| run('hdiutil', 'attach', '-nobrowse', '-readonly', '-mountpoint', str(mount), str(copied)) |
There was a problem hiding this comment.
DMG mount point is never created
High Severity
verify() attaches a DMG at work / 'mount' with hdiutil attach -mountpoint, but that directory is never created. hdiutil requires an existing empty mount point, so every DMG verification fails before the copied app is checked. ZIP-only Year View runs do not hit this path; shared Ledger and Marktext DMG gates do.
Reviewed by Cursor Bugbot for commit 70d0d73. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Year View's release instructions checked the exported app, while the download users install is a ZIP. Add a Year View-specific verifier that extracts the final ZIP into a temporary directory and checks bundle layout, identifier/version, Developer ID signing, the stapled ticket and Gatekeeper acceptance on a quarantined copy.
Keep the existing Xcode archive/export, notarization and app-stapling commands. Replace the shared release protocol with Year View's own ZIP and native calendar walkthrough instructions; remove cross-repository synchronization claims. There are no changes to signing identities, credentials, App Store configuration or application code.
Validation: