Repository navigation
Fix detached notarization feed checksum and localize release guidance - #17
peterjthomson wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0b03602. Configure here.
| run('xattr', '-w', 'com.apple.quarantine', '0081;00000000;ReleaseVerification;', str(copied)) | ||
| run('spctl', '--assess', '--type', 'open', '--context', 'context:primary-signature', str(copied)) | ||
| mount = work / 'mount' | ||
| run('hdiutil', 'attach', '-nobrowse', '-readonly', '-mountpoint', str(mount), str(copied)) |
There was a problem hiding this comment.
DMG mount point is never created
Medium Severity
DMG verification calls hdiutil attach -mountpoint on work/mount without creating that directory. Apple documents -mountpoint as requiring an existing empty path, so attach can fail with no such file or directory and the DMG half of the release gate never runs.
Reviewed by Cursor Bugbot for commit 0b03602. Configure here.
|
Build artifacts for PR #17: Run: https://github.com/peterjthomson/marktext/actions/runs/36123241538
|


The optional detached notarization helper updates an artifact's
files[]checksum after stapling but can leave the top-level legacysha512stale whenpathnames the same artifact. Refresh both digests, preserve the legacy ZIP digest when refreshing a different DMG, and cover both cases in the existing Vitest suite.Release guidance now describes Oh My Marktext's own build and native document-save checks. Remove the helper comments that require synchronization with other repositories.
The existing build commands, electron-builder notarization, DMG hook, post-build refresh step, signing documentation and conditional macOS release CI are unchanged from main.
Validation:
pnpm omm:deltas --checkpasses.