Repository navigation
Titlebar navigation, persistent list controls, and branch/PR fixes - #82
Open
peterjthomson wants to merge 1 commit into
Open
peterjthomson wants to merge 1 commit into
peterjthomson wants to merge 1 commit into
Conversation
Addresses a batch of small upgrades from daily use: - Titlebar back/forward buttons for editor history (VS Code style); back/forward now also restores repo and mailmap views. - List search/filter/sort live in a shared store, so they survive canvas and panel switches and stay in step between radar columns and Focus sidebar sections. Filter, sort, and section expansion persist across restarts. - Focus sidebar section controls are hoisted to module scope; they were being remounted on every refresh, which stole focus and closed open dropdowns. - Remote branch lists drop the remotes/<remote>/ prefix and commit hashes. - Branch commit counts start at the fork point from main/master rather than counting the whole history. - Renaming a remote branch no longer runs `git branch -m` on a remote ref. GitHub remotes use the branch-rename API so open PRs follow; other remotes push the new name and delete the old one. Tracking branches are retargeted. - PR detail card can rename (retitle) the PR via `gh pr edit`. - Line staging works for untracked files, and untracked diffs no longer include a phantom trailing empty line. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 863f775. Configure here.
| } | ||
| } else { | ||
| await git.raw(['push', remote, `refs/remotes/${remote}/${oldName}:refs/heads/${newName}`]) | ||
| await git.raw(['push', remote, '--delete', oldName]) |
There was a problem hiding this comment.
Stale tip can drop remote commits
Medium Severity
The non-GitHub rename pushes refs/remotes/<remote>/<oldName> as the new head and then deletes the live remote branch, without fetching first. A stale tracking ref can publish an old tip and drop commits that only existed on the remote.
Reviewed by Cursor Bugbot for commit 863f775. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
A batch of small upgrades from daily use:
app/stores/list-controls-store.tsholds search/filter/sort per list type. Radar columns and matching Focus sidebar sections share it. Filter, sort, and sidebar section expansion persist across restarts; search is session-only.SectionHeader/SectionFilterwere declared insideSidebar's render, so every background refresh remounted them (stealing focus, closing native<select>popups). Hoisted to module scope.feature/xinstead ofremotes/origin/feature/x(remote badge only when there are several remotes); commit hashes removed.origin/master→origin/main→master→main, not the whole history. main/master keep their full count.git branch -m remotes/origin/x …, giving "branch not found". Now GitHub remotes usegh api …/branches/{branch}/rename, so open PRs follow the rename (a failure is reported; there is no silent push+delete fallback that would close PRs). Other remotes push the new name and delete the old one. Local tracking branches are retargeted. A Rename button is added to the remote branch card.gh pr edit --title, via a newedit-pr-titleconveyor channel.does not exist in index); partial patches now create the file. Untracked diffs no longer include a phantom trailing empty line (which also made whole-file hunk staging add a blank line). The three duplicate untracked-diff builders now sharebuildUntrackedFileDiff.Test plan
npm run typecheckand eslint cleannpm test– full Playwright suite green, including new tests:Generated with Devin
Note
Medium Risk
Touches git remotes (rename, commit ranges), GitHub CLI/API for PR and branch renames, and staging patch generation—real repo mutation paths though scoped to explicit user actions.
Overview
Adds VS Code-style back/forward in the titlebar (alongside existing ⌘[ / ⌘]) and wires editor history to restore repo and mailmap views when navigating.
Introduces a shared
list-controls-storeso search, filter, sort, and sidebar section expansion stay aligned between Radar columns and Focus sidebar sections, survive canvas/panel switches, and persist filter/sort/section state across restarts. Sidebar filter UI is hoisted to module scope so list refreshes no longer remount controls and steal focus from inputs/dropdowns.Remote branches show short names (remote badge only when multiple remotes); commit counts count commits since fork from main/master. Rename remote branches from the detail card via GitHub’s branch-rename API on
origin(or push+delete elsewhere), with tracking branches updated. Rename open PR titles from the PR card through a newedit-pr-titleIPC path.Staging fixes line-level staging for untracked files and removes phantom trailing blank lines in untracked diffs via shared
buildUntrackedFileDiffandnewFilepartial patches.Reviewed by Cursor Bugbot for commit 863f775. Bugbot is set up for automated code reviews on this repo. Configure here.