Repository navigation
Verify Ledger release artifacts and add packaged-runtime CI - #81
Open
peterjthomson wants to merge 4 commits into
Open
peterjthomson wants to merge 4 commits into
peterjthomson wants to merge 4 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 08a4e0d. Configure here.
| raise ValueError('DMG must contain exactly one root app') | ||
| # Verify the installed copy as well as the disk image itself. | ||
| app = work / 'installed' / apps[0].name | ||
| run('ditto', str(apps[0]), str(app)) |
There was a problem hiding this comment.
DMG verification skips directory setup
High Severity
DMG verification always fails before any Gatekeeper or bundle checks. hdiutil attach -mountpoint needs an existing empty directory, and the later ditto into installed needs that parent too; neither path is created. ZIP-only runs still pass, so a broken DMG can miss the release gate that this change is meant to enforce.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 08a4e0d. Configure here.
peterjthomson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ledger v1.6.0 ships a ZIP, but the existing release verifier requires a DMG and only inspects ZIP filenames. Verify the extracted ZIP app's layout, identity/version, Developer ID signature, stapled ticket and Gatekeeper acceptance. Keep DMG verification and reject missing or stale update-feed artifacts, including stale legacy checksums. Fix the optional detached-notarization helper's legacy checksum refresh.
Add macOS CI for the existing test suite and unsigned packaged-runtime check. Record the observed DMG copy denial and App Store 1.5.1 rejection so those unresolved problems have concrete evidence and follow-up criteria.
Release instructions now describe Ledger's own build and Git walkthrough. Existing build commands,
npm run release, electron-builder signing/notarization and the shell notarization helper retain their prior behavior. There is no shared release orchestrator or requirement to synchronize other repositories.Validation:
npm ci, unsigned arm64 packaging with the restored configuration, and the packaged-runtime/SQLite smoke test pass.The DMG permission denial and App Store rejection remain unresolved. No release artifacts are published by this PR. Concurrent local application edits are excluded.