Compare php easter_date() with method getEasterSundayTester()#6
Open
h4kuna wants to merge 1 commit into
Open
Conversation
xelan
reviewed
Apr 7, 2021
| }, | ||
| "require-dev": { | ||
| "nette/tester": "^1.6" | ||
| "nette/tester": "^2.0" |
There was a problem hiding this comment.
Shouldn't ext-calendar be added as a dev-requirement to use easter_date() in the test?
Author
There was a problem hiding this comment.
First motivation for these changes are to replace this method by native php function. If these changes are confirmed, better way is add ext-calendar to require section.
There was a problem hiding this comment.
That method was created just a few weeks ago in order to avoid the dependency on ext-calendar 😉
See 01eb1bc
Author
There was a problem hiding this comment.
Ok, the method for get easter sunday is little magic. I understand, this PR does not make sence with previus goal. I undestand your notice, why add ext-calendar to dev-requirement. I prepare it.
| ]; | ||
| } | ||
|
|
||
| public function testPhpEasterDate() |
h4kuna
force-pushed
the
use-native-php-easter-date
branch
from
5b698e2 to
16515e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ahoj,
zkusil jsem porovnat implementovanou metodu pro získání velikonoční neděle s php funkcí easter_date() a dává to stejný výsledky.
Pokud by se ti to líbilo a změnu by jsi chtěl, upravil bych typo a dotáhnul PR.
Hello,
i try to compare implemented method for to get easter sunday with php native function easter_date() and results are same.
If you confirm this replace, i will update typo and i finish the PR.