Repository navigation
Add cbXRP token (Chain: 8453); mainnet wETH uses its own logo - #435
Merged
Merged
Conversation
- cbXRP (Coinbase Wrapped XRP) on Base, 0xcb585250f852c6c6bf90434ab21a00f02833a4af, 6 decimals (name/symbol/decimals read on chain). It is the underlying of the XRP Yield MetaVault; without an entry the API returns no logo and clients that build CDN URLs get a 404. Logo: Coinbase's cbXRP mark (CoinGecko, 250px). - Mainnet wETH's logoURI pointed at Base wETH's image. The mainnet entry ships its own (byte-identical) logo.svg, so it now references it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MetaVaults Earn (spectra-sdk PR #280) found two token-list gaps:
spectra-internalresolves logos through this list) returns nologoURIfor it. Clients that buildtokens.spectra.finance/images/tokens/8453/0xcb58….svgdirectly (Earn, curator-app) get a 404.logoURIpoints at Base wETH's image (/images/tokens/8453/0x4200….svg). WETH Optimizer on Ethereum therefore serves a Base asset as its underlying logo.What changes
src/tokens/8453/0xcb585250f852c6c6bf90434ab21a00f02833a4af/:name,symbolanddecimalsread on chain from Base: Coinbase Wrapped XRP · cbXRP · 6.coinbase-wrapped-xrp), 250×250 PNG.src/tokens/1/0xc02aaa39…/index.json:logoURI→/images/tokens/1/0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2.svg.logo.svg, byte-identical to Base's, and the CDN already serves it with a 200. Nothing changes visually.Not changed
0x26d460c3…, non-transferable reward token) is deliberately not added. A list entry could surface it in token pickers. Earn shows the Flare mark for it locally.ETH(0xEeee…) also references mainnet ETH's image. Native ETH is the same asset, so this is left as is.Verification
src/schema/token.schema.json, the schema the token-validation workflow uses.logoURIin the repo has itslogo.<ext>file, which is whatbuild.tscopies.🤖 Generated with Claude Code