Skip to content

Add engineering, code-review skills and make all skills generic#48

Merged
z26zheng merged 3 commits into
mainfrom
add-planning-skills
May 10, 2026
Merged

Add engineering, code-review skills and make all skills generic#48
z26zheng merged 3 commits into
mainfrom
add-planning-skills

Conversation

@z26zheng

@z26zheng z26zheng commented May 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #44 (which merged the initial 3 planning skills). This PR adds:

  • engineering skill: SOLID, YAGNI, DRY, fail-closed principles, implementation checklist, common mistakes
  • code-review skill: two-level review (line-by-line + systemic impact), severity definitions, review standards
  • skills/context.md: repo-specific conventions extracted so all 5 SKILL.md files are portable to any repository
  • Genericized all skills: removed all permit0-specific references from SKILL.md files; each points to context.md for local details
  • Parallel reviewer fix: auto-generated reviewer-id via uuidgen so parallel review agents write to separate subdirectories

Test plan

  • Verify engineering skill works: @skills/engineering/SKILL.md
  • Verify code-review skill works: @skills/code-review/SKILL.md
  • Confirm no permit0-specific references in any SKILL.md (rg permit0 skills/*/SKILL.md returns 0 matches)
  • Confirm context.md has all repo conventions
  • Test parallel plan reviews write to separate subdirectories

Made with Cursor

z26zheng and others added 3 commits May 10, 2026 14:20
…rites

Each reviewer agent now derives a unique subdirectory via uuidgen so
parallel review runs no longer clobber each other's output files.

Co-authored-by: Cursor <cursoragent@cursor.com>
General-purpose skill covering SOLID, YAGNI, DRY, fail-closed principles,
repo conventions, verification checklist, and common mistakes to avoid.

Co-authored-by: Cursor <cursoragent@cursor.com>
… generic

- Add skills/context.md with permit0-specific conventions, paths, and
  architecture
- Add code-review skill for thorough two-level code reviews
- Remove all permit0-specific references from the 5 SKILL.md files so
  they are portable to any repository
- Each skill now opens with a reference to context.md for repo-local details

Co-authored-by: Cursor <cursoragent@cursor.com>
@z26zheng z26zheng requested a review from AnissL93 as a code owner May 10, 2026 21:20
@z26zheng z26zheng merged commit ad57ef3 into main May 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant