impr: miscellaneous codec improvements for httpsig@1.0, tx@1.0 and ans104@1.0 - #1028
Merged
Conversation
Use GraphQL bundle ancestry to distinguish mined L1 transactions from ANS-104 data items. Load L1 transaction headers and raw data through the native tx codec so gateway reads retain their authenticated commitment type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three separate codec issues individually:
~arweave@2.9device.~ans104@1.0messages that have atargetkey that is not encodable as a commitmentfield-targetvalue. h/t to @NickJ202 's fix: stabilize process uploads and scheduling #1023 that raised an instance where this issue occurs in~scheduler@1.0. This commit patches the underlying issue but fix: stabilize process uploads and scheduling #1023's error handling should likely still land in some form.content-digestheaders for nested messages containing it. We separatecontent-digestinto its own, distinct multipart form component such that it does not collide with the othercontent-digestvalue needed for the message to be encoded.