fix: verify owner auth committers - #1003
Open
charmful0x wants to merge 2 commits into
Open
Conversation
| CommitmentID, | ||
| Commitment = | ||
| #{ | ||
| <<"commitment-device">> := <<"httpsig@1.0">>, |
Collaborator
There was a problem hiding this comment.
Should it search for the right device to call to verify?
| unclaimed -> unclaimed; | ||
| NativeAddress -> hb_util:human_id(NativeAddress) | ||
| end, | ||
| EncOperator == unclaimed orelse lists:member(EncOperator, RequestSigners). |
Collaborator
There was a problem hiding this comment.
Alternate for the complete patch, perhaps:
EncOperator == unclaimed orelse
(lists:member(EncOperator, RequestSigners)
andalso hb_message:verify(Request, #{ <<"committers">> => RequestSigners }, Opts))
If I remember the API correctly 😅
Collaborator
There was a problem hiding this comment.
Clanker suggested the verified_committers method, which allows specifying specific keys to be signed. This gives us control over which fields we need to make sure are signed, instead of a generic sign of a partial message.
On update node config, it checks if all configs were signed by the node operator. On is_operator request, since no key is given, it is just a normal hb_message:verify call.
speeddragon
reviewed
Jul 6, 2026
Co-authored-by: speeddragon <speeddragon@gmail.com>
charmful0x
force-pushed
the
fix/owner-auth
branch
from
July 6, 2026 20:13
5f42310 to
291b9a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry picked some fixes made by @speeddragon from #963