Repository navigation
Add CAN predicates, consolidate XS via ALIAS, unify test pipeline - #8
Merged
Merged
Conversation
Resolve the `UNIVERSAL::can` debacle by providing predicates that call `->can` as a method rather than as a function, respecting any overridden `can()` in the invocant's class hierarchy. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jens Rehsack <sno@netbsd.org>
Maintaining two near-identical test trees violated DRY and SPOT. Canonical tests now live in t/inline/; Sandbox/Tumble.pm generates the backend-specific variants during `perl Makefile.PL`. See lib/Params/Util/ADR-001.pod for the full rationale. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jens Rehsack <sno@netbsd.org>
ADR-002: Multi-method signatures for `_CAN` and `_DOES` (proposed) ADR-003: `Params::Util::Assert` assertion variants (proposed) ADR-004: `Test::Params::Util` as separate distribution (proposed) Cross-reference the ADRs from the TO DO section in the main POD so future contributors find the design context directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jens Rehsack <sno@netbsd.org>
RT is kept as historical reference but GitHub Issues is now the primary channel for bugs and feature requests. Also update the copyright year range. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jens Rehsack <sno@netbsd.org>
Refactor _INSTANCE/_INSTANCECAN into a single ALIAS group (Group 4) and add XS implementations for all previously PP-only predicates: - Group 1: _IDENTIFIER, _CLASS - Group 2: _POSINT, _NONNEGINT - Group 3: _CLASSISA, _CLASSDOES, _CLASSCAN, _SUBCLASS - Group 5: _INVOCANT, _INVOCANTCAN See ADR-005 for the rationale behind using ALIAS over duplicated XSUBs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jens Rehsack <sno@netbsd.org>
Exercises both success and failure paths through call_method to verify ENTER/SAVETMPS/FREETMPS/LEAVE stack handling is leak-free. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jens Rehsack <sno@netbsd.org>
Captures the non-obvious conventions: container-only workflow, the PP/XS dual implementation with PP fallback, the Test::WriteVariants generation pipeline, the XS ALIAS groups, the author-test gates, and the asymmetric `Foo`/`Bar`/`Baz`/`Bad` test fixtures that discriminate `_ISA` from `_CAN`/`_DOES`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Jens Rehsack <sno@netbsd.org>
Skip 1.104 to leapfrog the unauthorised ETHER/Params-Util-1.103_01 upload that was numerically shadowing the 1.103_001 release on MetaCPAN (1.10301 > 1.103001 in Perl's decimal version comparison). Also extend `realclean` to mop up `inc/latest*`, `inc/inc_*`, `config.log`, and `M*.bak` so a freshly cloned dev checkout returns to a pristine state without manual cleanup. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Jens Rehsack <sno@netbsd.org>
rehsack
force-pushed
the
feature/provide-can
branch
from
May 2, 2026 13:57
1f3fbb4 to
539b969
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_CLASSCAN,_INSTANCECAN,_INVOCANTCAN— resolve theUNIVERSAL::candebacle by calling->canas a method, respecting overriddencan()in the invocant's class hierarchy_SET/_SET0/_HANDLE/_DRIVERnow have XS accelerators.t/ppandt/xswith aTest::WriteVariantspipeline. Canonical tests live int/inline/; backend variants are generated atperl Makefile.PLtime and shipped in the distributiont/inline/10_leaks.texercises both success and failure paths throughcall_methodto verify ENTER/SAVETMPS/FREETMPS/LEAVE handlinglib/Params/Util/document the pipeline, deferred designs (multi-method_CAN/_DOES,Params::Util::Assert,Test::Params::Util), and the ALIAS rationalerealcleanTest plan
make testpasses (2147 tests, all author-test gates green: perltidy, perlcritic, pod, spelling, manifest, kwalitee)make disttestpasses (2068 tests against the dist-tarball layout, no Sandbox)t/inline/)🤖 Generated with Claude Code