Repository navigation
Skip building XS when PUREPERL_ONLY=1 set - #2
Conversation
|
I see there is not a CI configuration running any more (previously Travis CI). Would it help to use GitHub Actions to test this out? |
|
I would love a PR which test whether this provides a reasonable and working change :) |
When `PUREPERL_ONLY=1` set, this prevents the Makefile from having rules that compile the XS code. This is useful to have when building dependencies for deploying to a pure Perl install such as when using `App::FatPacker`. This removes the need to skip over files that end in `perl -V:dlext` (e.g., `.so`, `.dll`, `.dylib`) when copying to a deployment. This should allow for using the `cpanm --pureperl` option so that a pure Perl installation can be requested for all installed distributions. Signed-off-by: Zakariyya Mughal <zaki.mughal@gmail.com>
31e9276 to
4c9b0c9
Compare
|
Hi, if you have time, could you review this. It should be working on multiple platforms per the new CI workflow. |
|
@rehsack, just reaching out again about this PR. |
|
@rehsack, hello, do you have a moment to review this PR? |
This is to test that the tests pass as expected under various versions of Perl both using XS and pure Perl installs. Signed-off-by: Zakariyya Mughal <zaki.mughal@gmail.com>
4c9b0c9 to
3afa712
Compare
|
Hello @rehsack, I just ran the CI I made here again and it still passes. I also added a few more Perl versions to test against. |
|
can confirm that this one line patch makes it work. What is currently on CPAN does not. |
|
If you do not have access to PAUSE or the time to do it yourself you can also email the PAUSE admins at modules@perl.org and ask them to do it for you, they will be only to happy to do so. |
XS doesn't work for a fat packed script ( I'm not sure how this is relevant to the discussion of the ownership/co-maint status though, you yourself said that you are not interested in maintaining this module, why not let us take it off your hands? |
This change skips the static/dynamic sections of the Makefile when using a
pure-Perl install so that no XS linking is done at all.
Compare the build logs below: