Render Header and Footer statically instead of as server islands#747
Open
jamiefolsom wants to merge 2 commits into
Open
Render Header and Footer statically instead of as server islands#747jamiefolsom wants to merge 2 commits into
jamiefolsom wants to merge 2 commits into
Conversation
Their content only changes on CMS publish, so per-request island rendering buys nothing and costs two SSR round-trips per page view. Active-nav state now comes from the page's own pathname (passed down from Layout) instead of the Referer header, which also removes the island-without-Referer failure mode (#743) for these components and lets static builds render them at build time. HeaderContainer's client:load transparency wrapper is unchanged; content islands (posts, detail pages, home) are untouched.
✅ Deploy Preview for padp-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-ancestry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pss-scavenger-hunt ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for marronage-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for relnet-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-life ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jamiefolsom
marked this pull request as ready for review
July 14, 2026 17:17
Contributor
|
I suppose before merging, in addition to resolving conflicts, I'd like to understand why some of the deploy previews (but not others) are just rendering blank pages (see the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #745. Draft — intended to land after #746 (the cache TTL/purge PR), whose CDN caching absorbs the cost of moving the navbar queries into the page render.
Header and Footer content (nav, translations, branding) only changes on CMS publish, but as server islands they cost two extra SSR round-trips per page view — 0.15–2.2 s each on cache misses in this week's measurements — and they fail entirely when an island request has no Referer header (#743), since that's where an island learns what page it's on.
Changes:
Layout.astro:server:deferremoved from Header and Footer; each receivespathname={Astro.url.pathname}.Header.astro/Footer.astro: active-nav state and the language picker use thepathnameprop instead of the Referer; their per-islandsetCacheControlcalls are gone (the page response, which now contains them, is already covered by Layout).getCurrentURLdeleted fromsrc/utils/url.ts— these were its only callers.Not touched:
HeaderContainer client:load(transparency wrapper), content islands (posts, paths, pages, detail pages, home).Why prop threading instead of client-side
location.pathname: NavBar renders on the server, and the CDN cache key is the URL, so every cached page carries its own correct active state — including underSTATIC_BUILD, where header/footer previously never resolved at all (islands need a server).Verified: vitest suite green; components compile in a static build (which then fails at a pre-existing, unrelated
getStaticPathscrash inapi/gallery/[manifestId].json.tswhen the config has no gallery — identical failure on develop; separate issue to follow). Render-level QA: deploy preview — check a custom-navbar site and a default-navbar site, active-nav highlighting, mobile header, and the language picker on a multi-locale site.