Adding sensitive content warning/filter to detail and search#571
Open
ajolipa wants to merge 1 commit into
Open
Adding sensitive content warning/filter to detail and search#571ajolipa wants to merge 1 commit into
ajolipa wants to merge 1 commit into
Conversation
✅ Deploy Preview for padp-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pss-scavenger-hunt ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for gbof-c19nyc-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-ancestry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for universities-studying-slavery ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-life ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for registro-project ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for libertos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for gamepossible ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
camdendotlol
requested changes
Jun 25, 2026
camdendotlol
left a comment
camdendotlol
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a couple small changes.
| const config = useSearchConfig(); | ||
|
|
||
|
|
||
| if (!(config.type === 'image')) { |
Contributor
There was a problem hiding this comment.
Let's do config.type !== 'image' for clarity
|
|
||
| const service = ServiceFactory.getService(model); | ||
| const manifests = await service.getRelatedManifests(uuid); | ||
| const { mediaContents } = await service.getRelatedMedia(uuid); |
Contributor
There was a problem hiding this comment.
The content warning field should be included in the manifests, so it would be better for load times to get it from there instead of adding a second fetch request.
See
for an example that can probably be factored out into a helper function and shared between this component and that one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
This PR does two things:
content_warning: true;Notes
content_warningfield work better on front end core-data-cloud#557