docs: a Loki tenant goes in the relay headers, not in Setup - #11
Merged
Merged
Conversation
Perfloop refuses a tenant for a relay source, as it refuses a credential (proxy/telemetry_relay_test.go in perfloop/perfloop). Step 6 told the reader to enter it in Setup, which fails validation. The tenant belongs in the upstream's X-Scope-OrgID header, as docs/security.md already says. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 6 of docs/setup.md told a reader with a multi-tenant Loki to enter the tenant id in Perfloop Setup. Perfloop refuses a tenant for a relay source, as it refuses a credential (perfloop/perfloop
proxy/telemetry_relay_test.go: "relay source accepted a provider tenant"), so that connection fails validation. The step now says to leave the tenant empty and putX-Scope-OrgIDin the upstream'sheaders, which docs/security.md already describes.Found while writing the customer guide, perfloop/perfloop#4306, which links this file.
🤖 Generated with Claude Code