Skip to content

OpenTui fix - #10

Merged
pentoshi007 merged 2 commits into
pentoshi007:mainfrom
pent0shi:main
Sep 5, 2026
Merged

OpenTui fix#10
pentoshi007 merged 2 commits into
pentoshi007:mainfrom
pent0shi:main

Conversation

@pent0shi

@pent0shi pent0shi commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issue

Closes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • ♻️ Refactor (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test update
  • 🔧 Chore (build, CI, dependencies, tooling)

How Has This Been Tested?

  • npm run typecheck passes
  • npm test passes
  • Manual testing (describe below)

Test Details

Screenshots / Recordings

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published

usehoplite Bot and others added 2 commits September 5, 2026 10:47
The OpenTUI renderer emits private CSI sequences such as kitty keyboard
push flags (CSI >...u) whose leading '>' crashed the screen probe's
int() parse, failing resize-repaint.pty.py under the parity suite.
The CSI regex already admitted ?<>; strip all of them, not just ?.

Co-authored-by: Aniket Pandey <ak802135@gmail.com>
fix(pty-probe): strip < and > private CSI markers before numeric parse
Copilot AI lite review requested due to automatic review settings September 5, 2026 10:56
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 779e6914-19ef-4680-980a-61485e512189


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is small, aligns with the existing CSI regex contract, and prevents a concrete parsing failure without altering unrelated behavior.

Pull request overview

This PR updates the PTY “smoke” probe’s CSI parsing logic so it correctly handles additional CSI private marker prefixes, preventing numeric parameter parsing errors for sequences like kitty keyboard CSI >...u and device attribute replies.

Changes:

  • Treat ?, <, and > as valid CSI private markers and strip them before parsing numeric parameters.
  • Add an explanatory comment aligning the parsing logic with the existing CSI_RE regex.
File summaries
File Description
scripts/pty-smoke.py Expands CSI private-marker handling to avoid int() parse failures for CSI <... / CSI >... sequences.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pentoshi007
pentoshi007 merged commit f181469 into pentoshi007:main Sep 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants