Support Alfredpay BANK_USA CHECKING isExternal: true#1130
Conversation
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sharqiewicz
requested review from
ebma and
gianfra-t
and removed request for
ebma
There was a problem hiding this comment.
Pull request overview
This PR updates the Alfredpay fiat account creation flow to support BANK_USA checking accounts marked as isExternal: true, aligning the payload shape with what Alfredpay expects for external US bank accounts.
Changes:
- Move
isExternalout offiatAccountFieldsand into the top-levelCreateAlfredpayFiatAccountRequestpayload. - For
BANK_USAaccounts, send bank address fields insidefiatAccountFields.metadatawhenisExternal === true. - Frontend updates: minor Framer Motion layout tweaks and translation updates.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/services/alfredpay/types.ts | Adjusts shared Alfredpay request/field types: moves isExternal to request-level and adds bank address fields to metadata. |
| packages/shared/src/services/alfredpay/alfredpayApiService.ts | Extends createFiatAccount to accept isExternal and includes it in the POST payload. |
| apps/api/src/api/controllers/alfredpay.controller.ts | Maps BANK_USA external account address fields into metadata and forwards isExternal to shared service. |
| apps/frontend/src/pages/alfredpay/FiatAccountRegistration/AccountCardDeck.tsx | Adds AnimatePresence mode and layoutId to improve card transitions. |
| apps/frontend/src/constants/fiatAccountForms.ts | Changes the “saving(s)” account type option value from SAVINGS to SAVING. |
| apps/frontend/src/translations/pt.json | Adds/updates multiple PT strings; introduces a new partnerCpf key and a title2 string. |
| apps/frontend/src/translations/en.json | Changes “Savings” label to “Saving” for the saving account type option. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "nequi": "Nequi", | ||
| "ownAccount": "My own account", | ||
| "saving": "Savings" | ||
| "saving": "Saving" |
There was a problem hiding this comment.
components.fiatAccountForms.options.saving is translated as "Saving", which is grammatically incorrect for a bank account type (should be "Savings"). This is user-facing and will show up in the account type dropdown.
| "saving": "Saving" | |
| "saving": "Savings" |
There was a problem hiding this comment.
I agree. I think the US american account type is always 'Checking' or 'Savings', not 'Saving'.
| "fullName": "Nome Completo", | ||
| "number": "Número", | ||
| "partnerCpf": "CPF do Parceiro", | ||
| "partnerCpff": "CPF do Parceiro", |
There was a problem hiding this comment.
This file now contains both partnerCpf (added) and the existing partnerCpff key. Since the codebase references partnerCpf (and there are no references to partnerCpff), keeping the typo key is confusing and makes translation maintenance harder. Consider removing partnerCpff (or migrating any remaining usages to partnerCpf if they exist).
| "partnerCpff": "CPF do Parceiro", |
| "subtitle": "O app hospedado da Vortex é a maneira mais rápida de adicionar uma rampa fiat on/off segura ao seu app.", | ||
| "title": "Uma integração. Tudo resolvido." | ||
| "title": "Uma integração. Tudo resolvido.", | ||
| "title2": " Tudo resolvido." |
There was a problem hiding this comment.
pages.business.whyVortexBusiness.title2 has a leading whitespace (" Tudo resolvido.") which will render as an odd indent at the start of the line. Remove the leading space and handle spacing in the JSX layout if needed.
| "title2": " Tudo resolvido." | |
| "title2": "Tudo resolvido." |
| }, | ||
| "progress": { | ||
| "alfredPayOfframpTransfer": "Inicializando transferência para sua conta bancária.", | ||
| "alfredpayOfframpTransfer": "Inicializando transferência para sua conta bancária.", |
| "nequi": "Nequi", | ||
| "ownAccount": "My own account", | ||
| "saving": "Savings" | ||
| "saving": "Saving" |
There was a problem hiding this comment.
I agree. I think the US american account type is always 'Checking' or 'Savings', not 'Saving'.
…and conditional sections
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.