Rewrite eviction module#14
Open
brayniac wants to merge 1 commit intopelikan-io:mainfrom
Open
Conversation
brayniac
force-pushed
the
brayniac/rewrite-eviction
branch
2 times, most recently
from
244f80b to
a7e51a4
Compare
Rewrite Policy enum and Eviction struct. Policy doc comments now explain *why* each strategy works, not just what it does. Eviction rerank() uses a function pointer instead of duplicating the match arms, and comparators use Ord instead of manual if-chains. ghost.rs is unchanged (already clean). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
brayniac
force-pushed
the
brayniac/rewrite-eviction
branch
from
a7e51a4 to
0e7c48a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eviction/mod.rsandeviction/policy.rsrerank()uses a function pointer dispatch instead of duplicating match armsOrd/.cmp()instead of manual if-chainsghost.rsunchanged (already clean)Test plan
cargo test --workspace— 88 tests passcargo test -p segcache --features debug— 55 tests passcargo clippy --workspace --all-features --all-targets -- -D warnings— cleancargo fmt --all --check— clean🤖 Generated with Claude Code