Skip to content

Android: log the window surface retry once per trip to the background #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peiikai merged 1 commit into from
Nov 13, 2026
Merged

Android: log the window surface retry once per trip to the background #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions runtime/nvn/vulkan/device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,20 +1162,24 @@ static void create_swapchain(void) {
// Android destroys the window's surface whenever another activity covers the app (the folder picker, the home screen)
// and SDL makes a new one on return: the old VkSurfaceKHR is lost for good (VK_ERROR_SURFACE_LOST_KHR on every acquire,
// a black screen). So each swapchain rebuild there makes the surface again from SDL's current window first; the old
// swapchain belongs to the old window and can't be passed on. False: no window right now (in the background).
// swapchain belongs to the old window and can't be passed on. False: no window right now (in the background). That
// is tried again every frame while the app is away, so it is logged once: the first try, and the count on return.
static bool recreate_surface(void) {
static unsigned misses;
for (uint32_t i = 0; i < g_vk.sc_count; i++) vkDestroyImageView(g_vk.dev, g_vk.sc_views[i], NULL);
g_vk.sc_count = 0;
if (g_vk.swapchain) vkDestroySwapchainKHR(g_vk.dev, g_vk.swapchain, NULL);
g_vk.swapchain = VK_NULL_HANDLE;
if (g_vk.surface) vkDestroySurfaceKHR(g_vk.inst, g_vk.surface, NULL);
g_vk.surface = VK_NULL_HANDLE;
if (!SDL_Vulkan_CreateSurface(window, g_vk.inst, NULL, &g_vk.surface)) {
LOG("[vk] no window surface yet: %s\n", SDL_GetError());
if (!misses++) LOG("[vk] no window surface yet: %s (tried again each frame, not logged)\n", SDL_GetError());
g_vk.surface = VK_NULL_HANDLE;
return false;
}
LOG("[vk] window surface made again (the app was in the background)\n");
if (misses) LOG("[vk] window surface made again (the app was in the background; %u tries without a window)\n", misses);
else LOG("[vk] window surface made again (the app was in the background)\n");
misses = 0;
return true;
}
#endif
Expand Down
Loading