Skip to content

Finish coding challenge #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewyang96 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Finish coding challenge #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8037e30
ez
andrewyang96 Sep 17, 2016
1c23137
Make BigDecimal
andrewyang96 Sep 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions your_return_calculator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,15 @@ def calculate!
# snapshot.date
# snapshot.cash_flow
# snapshot.market_value

BigDecimal.new(0)
previous_snapshot = nil
total_return = BigDecimal.new(1)
for snapshot in snapshots do
if previous_snapshot != nil then
period_return = (snapshot.market_value - snapshot.cash_flow) / previous_snapshot.market_value
total_return = total_return * period_return
end
previous_snapshot = snapshot
end
return total_return - 1
end
end