Skip to content

fix(parser): abort expanding recurring events when end is reached - #35

Closed
tripodsan wants to merge 1 commit into
peerigon:masterfrom
tripodsan:recurring-fix
Closed

fix(parser): abort expanding recurring events when end is reached#35
tripodsan wants to merge 1 commit into
peerigon:masterfrom
tripodsan:recurring-fix

Conversation

@tripodsan

Copy link
Copy Markdown

fixes #34

  • the fix extends the parser by allowing to specify the desired start end end range.
  • recurring events are expanded until:
    1. completed, or
    2. when reaching the specified end range
    3. or 10 times, when no end range is specified

@movd

movd commented May 4, 2020

Copy link
Copy Markdown

could this please be merged?

@antosan

antosan commented May 27, 2021

Copy link
Copy Markdown
Contributor

Thank you @tripodsan for your PR. While reviewing we noticed that the implementation of the parser regarding the expansion was a little buggy. We expanded all the events from the start date and had to filter them again afterwards. We refactored this buggy behaviour in the parser and took into consideration your suggestions as well in #48.

@antosan antosan closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recurring events not expanded to full range

3 participants