fix(parser): abort expanding recurring events when end is reached - #35
Closed
tripodsan wants to merge 1 commit into
Closed
fix(parser): abort expanding recurring events when end is reached#35tripodsan wants to merge 1 commit into
tripodsan wants to merge 1 commit into
Conversation
|
could this please be merged? |
Contributor
|
Thank you @tripodsan for your PR. While reviewing we noticed that the implementation of the parser regarding the expansion was a little buggy. We expanded all the events from the start date and had to filter them again afterwards. We refactored this buggy behaviour in the parser and took into consideration your suggestions as well in #48. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #34