Skip to content

feat: accurate source locations for schema diagnostics (#171) - #173

Merged
pedrosakuma merged 1 commit into
mainfrom
feat/schema-diagnostic-locations
Aug 29, 2026
Merged

feat: accurate source locations for schema diagnostics (#171)#173
pedrosakuma merged 1 commit into
mainfrom
feat/schema-diagnostic-locations

Conversation

@pedrosakuma

Copy link
Copy Markdown
Owner

Summary

  • capture XML element/attribute source locations during schema parsing and carry them through DTOs
  • report schema diagnostics against the relevant XML location when available, including parse-time and downstream generation-time validation paths
  • document the new behavior and add end-to-end tests covering missing attributes, invalid integer attributes, and sinceVersion diagnostics

Validation

  • dotnet build
    • Build succeeded
    • 0 Warning(s)
    • 0 Error(s)
  • dotnet test
    • SbeCodeGenerator.Tests: Passed 196/196
    • SbeCodeGenerator.IntegrationTests: Passed 168/168

Closes #171

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pedrosakuma
pedrosakuma force-pushed the feat/schema-diagnostic-locations branch from e79799f to 051be5f Compare August 29, 2026 14:10
@pedrosakuma
pedrosakuma merged commit 2002de8 into main Aug 29, 2026
1 check passed
@pedrosakuma
pedrosakuma deleted the feat/schema-diagnostic-locations branch August 29, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DX: schema diagnostics always report Location.None (no line/column in XML)

1 participant