pen: drop grounding + marker lock for semantic mates (equiv #110) - #116
Open
pedropaulovc wants to merge 1 commit into
Open
pen: drop grounding + marker lock for semantic mates (equiv #110)#116pedropaulovc wants to merge 1 commit into
pedropaulovc wants to merge 1 commit into
Conversation
pedropaulovc
force-pushed
the
pen-unground
branch
from
June 27, 2026 21:24
ecb009c to
0539d0c
Compare
Remove every fix and the one lock from the pen subassembly, matching #110: only the first-inserted pen-hanger stays auto-fixed as the seed. - pen-hanger -> ground=False (seed); pen-v-block, pen-frame, pen-set-screw, hanger-screw -> datum-located (orientation-agnostic helper handles the Ry90*Rx90 frame). - pen-marker: the lock_mate (rides the rod's Y-prismatic travel) becomes three orthogonal plane mates to the ROD's frame, so the marker still follows the rod as the pen driver drives it -- with no lock. - pen-rod's prismatic mates and the F5 pen_driver equation are UNTOUCHED. Standalone build (cache off, full from-scratch): gate.dof components=7 fixed=1 pattern=0 not_fully_defined=0; interference hits=0; deep gate.health targets=8 errors=0 warnings=0; pen driver still installs (20-link chain, rest 90 deg). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UasSn4u2NaoAyT47JMyMqV
pedropaulovc
force-pushed
the
pen-unground
branch
from
July 4, 2026 21:58
0539d0c to
249c2ae
Compare
pedropaulovc
force-pushed
the
pen-unground
branch
from
July 15, 2026 00:26
249c2ae to
db608b8
Compare
pedropaulovc
force-pushed
the
pen-unground
branch
from
July 15, 2026 01:49
db608b8 to
2b81e18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes every fix and the one lock from the pen subassembly, the same cleanup as #110 / #113 / #114 / #115. Only the first-inserted
pen-hangerstays auto-fixed as the seed.What changed
pen-hanger→ground=False(seed);pen-v-block,pen-frame,pen-set-screw,hanger-screw→ datum-located (the orientation-agnostic helper handles theRy90·Rx90frame).pen-marker: itslock_mate(it rides the rod's Y-prismatic travel) becomes three orthogonal plane mates to the rod's frame, so the marker still follows the rod as the pen driver drives it — with no lock.pen-rod's prismatic mates and the F5pen_driverequation are untouched.Verification
Standalone build, cache off, full from-scratch:
gate.dof→ components=7 fixed=1 pattern=0 not_fully_defined=0gate.interference→ hits=0gate.health→ targets=8 errors=0 warnings=0🤖 Generated with Claude Code
Warning
Rebased onto
mainby automated PR triage on 2026-07-04 — NOT build-verified.This branch was force-pushed after a mechanical rebase onto current
main(it was ~130-140 commits behind). The change is mechanically correct, but SolidWorks build/verify was not run (single COM seat, could not validate in parallel), so the three-part merge gate is still pending: rundoit assembly:pen verify:soundness verify:kinematics, get Codex clean, and eye-pass the renders before merging.Rebase details: A clean textual rebase was semantically broken — main's newer
pen-wire(WIRE 2) still callslock_mate; fixed by retaining thelock_mateimport. pen-wire's own lock was left as-is (out of this PR's scope; ungrounding it is a reasonable follow-up needing CAD sign-off).