Merged
Conversation
Collaborator
|
@markwalet Looks good from what I can see. I'll take a closer look after my vacation. Sure we can get this merged soon. |
Contributor
Author
|
@c0nst4ntin Hi there, hope you had a great vacation. Do you need any help with testing the PR or is there anything else I can do to support? Please let me know. Thanks! |
Closed
Collaborator
|
@markwalet Came back yesterday. Thank you for the great contribution. Test look good to me! |
Collaborator
|
@markwalet Merged and new version tagged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Symfony Console deprecated Application::add() in Symfony 7 and removed it in Symfony 8. This package still supports Symfony 6, so instead of adding version-specific conditionals we moved to the command-loader API, which is supported across Symfony 6/7/8.
Tests were executed on my own fork and the complete test matrix seems to be successful.
Related:
(#169)