Repository navigation
VocalErrorNetV2: keep NMDA off - #20
Merged
Merged
Conversation
The legacy class passes its old defaults explicitly, but g_nmda was not in its signature, so it inherited the new operating-point default (60) and silently gained NMDA; finchsim's AIV tonic-rate test, built from those defaults, went from ~14 to 89 Hz. It now passes g_nmda=0.0, and the pinned test checks that inherited operating-point features stay off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VocalErrorNetV2pins its old defaults by passing them explicitly, butg_nmdaisn't in its signature. It therefore inherited the new operating-point default (60) from #19 and silently gained NMDA. finchsim builds networks from those defaults, and its AIV tonic-rate test went from ~14 Hz to 89 Hz.VocalErrorNetV2now passesg_nmda=0.0.207 tests pass; finchsim's AIV tests pass against this branch.
🤖 Generated with Claude Code