Extract i18n to JSON and consolidate page templates - #21
Open
Victor1890 wants to merge 6 commits into
Open
Conversation
Victor1890
marked this pull request as ready for review
July 18, 2026 02:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces 108 duplicated per-locale HTML pages with 5 shared templates + 18 JSON locale files. Fixes nav bugs, flattens
engine.js, drops dead code.Why
Each locale had its own copy of every page. One string change meant editing 18 files — and they had drifted, shipping real bugs:
window.location.heftypo (9 locales — dead Continue button)href=\'...\'backslash escape (8 locales — dead Back button, 5 pages each)page_theme.htmllinked from nowhere (18 copies)welcome.htmlunreachable (main.jsloadshello.html)What changed
app/lg/<locale>/app/i18n/<locale>.json+i18n.jsonclickper buttonSTEPS[]+data-navorchestratorcommit()readFileSyncvalidateUser(), matchespost_setupindex.htmlfinish.htmlsetTimeout(commit, 10000)onload="commit()"Files
Added (24)
app/i18n/*.json— 18 locale string filesapp/templates/{keymap,timezone,user,agreement,finish}.htmlapp/js/i18n.jsModified (2)
app/index.html— trimmed to language-select onlyapp/js/engine.js— nav orchestrator, flattened commit, unified validationDeleted (111)
app/lg/<locale>/*.html(108 files)app/js/final-movement.js,app/js/focus-fix.jsapp/welcome.htmlBehavior preserved
language select → keymap → timezone → user → agreement → finish → commit() → IPC run-post-setup. Test mode (POST_INSTALL_TEST=1) unchanged. IPC arg order preserved (matchespost_setup).How to test
Walk: pick language → Continue → keymap → Continue → timezone → Continue → fill user form → Continue → agreement → Continue → finish (test mode closes without running
post_setup).