fix(ci): handle content guard diffs above 300 files - #2634
Closed
kushagrasarathe wants to merge 1 commit into
Closed
fix(ci): handle content guard diffs above 300 files#2634kushagrasarathe wants to merge 1 commit into
kushagrasarathe wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughThe content publish automerge workflow now retrieves all pull-request filenames through the paginated GitHub Files API before applying the existing exact ChangesContent file detection
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Code-analysis diffPainscore total: 6352.71 → 6352.71 (0) |
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/content-publish-automerge.yml (1)
67-67: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winRequest the maximum page size.
The Files API returns 30 files per page by default and accepts up to 100. For a 759-file pull request,
per_page=100reduces the requests from 26 to 8. This lowers latency and API rate-limit usage while preserving--paginate. (docs.github.com)Suggested change
- FILES=$(gh api --paginate "repos/$REPO/pulls/$PR/files" --jq '.[].filename') + FILES=$(gh api --paginate "repos/$REPO/pulls/$PR/files?per_page=100" --jq '.[].filename')🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/content-publish-automerge.yml at line 67, Update the gh api invocation assigned to FILES to request the maximum supported page size by adding per_page=100 to the pulls files endpoint, while preserving the existing --paginate behavior and filename jq filter.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/content-publish-automerge.yml:
- Line 67: Update the gh api invocation assigned to FILES to request the maximum
supported page size by adding per_page=100 to the pulls files endpoint, while
preserving the existing --paginate behavior and filename jq filter.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1f3938d9-9a2e-4f79-815b-813b6ca9dd3a
📒 Files selected for processing (1)
.github/workflows/content-publish-automerge.yml
Contributor
Author
|
Superseded by #2636, which combines this change with the Capgo workflow fix and targets dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
gh pr diff --name-onlyreturns HTTP 406 for pull requests with more than 300 files. Underset -e, that harmless non-content PR becomes a false-redapprove-and-mergecheck.Fix
Use GitHubs paginated pull-request Files API. The guard still auto-merges only when the complete file list is exactly
src/content.Verification
Summary by CodeRabbit