fix(i18n): four locale gaps — spinner words, savings message, Crisp locale, date casing - #2618
Merged
Conversation
The payment spinner cycled through 34 hardcoded English gerunds for every locale. The copy moves into the catalogs under paymentLoading; words.ts keeps only the key list, and CyclingLoading translates at render.
getSavingsMessage built the string in English for every locale. The cents/dollars split moves into ICU messages (qrPay.success.savedVsCard*) resolved at render; the now-unused util is removed.
The proxy never told Crisp which language the app runs in, so the chatbox always booted in English. The app locale now rides the proxy URL and lands in CRISP_RUNTIME_CONFIG.locale (es-419/es-AR map to es, pt-BR to pt-br).
The history and notifications group headers carried Tailwind 'capitalize',
which uppercases every word of the Spanish date ('24 De Julio De 2026').
The catalogs already ship 'Today'/'Hoy' capitalized, so the class only
ever did damage.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe change localizes payment loading and QR savings messages, propagates application locale values to Crisp, and removes forced capitalization from history and notification date headers. ChangesPayment localization
Crisp locale propagation
Date header styling
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Contributor
Code-analysis diffPainscore total: 7061.25 → 7055.03 (-6.22) 🆕 New findings (18)
✅ Resolved (18)
📈 Painscore deltas (top movers)
|
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx (1)
1246-1258: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd coverage for the cents message path.
This test only exercises
savedVsCardDollarswith150cents. Add cases below100cents, including1and a plural value. This verifies the threshold and both plural branches.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/`(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx around lines 1246 - 1258, Add test cases near the existing savings assertion in completeMantecaPayment coverage for calculateSavingsInCents values below 100, including 1 cent and a plural cent amount. Assert the localized savings message uses the cents format and both singular and plural wording, while preserving the existing 150-cent dollar-path case.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/app/`(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx:
- Around line 1246-1258: Add test cases near the existing savings assertion in
completeMantecaPayment coverage for calculateSavingsInCents values below 100,
including 1 cent and a plural cent amount. Assert the localized savings message
uses the cents format and both singular and plural wording, while preserving the
existing 150-cent dollar-path case.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 40dd1e21-9829-4599-b026-9c3dfb3f2e74
📒 Files selected for processing (13)
src/app/(mobile-ui)/history/page.tsxsrc/app/(mobile-ui)/notifications/page.tsxsrc/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsxsrc/app/(mobile-ui)/qr-pay/page.tsxsrc/app/crisp-proxy/page.tsxsrc/app/dev/loading-words/page.tsxsrc/components/Global/PeanutLoading/CyclingLoading.tsxsrc/components/Global/PeanutLoading/words.tssrc/hooks/useCrispProxyUrl.tssrc/i18n/app/messages/en.jsonsrc/i18n/app/messages/es-419.jsonsrc/i18n/app/messages/pt-BR.jsonsrc/utils/qr-payment.utils.ts
💤 Files with no reviewable changes (1)
- src/utils/qr-payment.utils.ts
Contributor
Author
|
CodeRabbit nitpick addressed: added |
jjramirezn
marked this pull request as ready for review
August 5, 2026 18:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four user-reported locale gaps, one commit each:
Cracking,Outsmarting SWIFT, …) in every locale. The 34 words move into the message catalogs underpaymentLoading(en / es-419 / pt-BR; es-AR inherits es-419 — the words carry no second-person conjugation).words.tskeeps only the typed key list;CyclingLoadingtranslates at render. The/dev/loading-wordspreview reads the English catalog directly.getSavingsMessage(). The cents/dollars split now lives in ICU messages (qrPay.success.savedVsCardCents|Dollars) resolved withuseTranslations; the util is removed and its mock dropped from the qr-pay test, which now asserts the real catalog string.CRISP_RUNTIME_CONFIG.locale(es-419/es-AR →es, pt-BR →pt-br). Capacitor's native Crisp messenger follows the device language and is untouched.capitalize, title-casing every word of the localized date. The catalogs already ship "Today"/"Hoy" capitalized, so the class is simply removed.Risks / breaking changes
QA
tsc --noEmitclean; full jest: only the pre-existing env-dependentadd-money-stateslocal failure (green in CI, red on clean origin/dev locally).Screenshots: N/A for 1–3 (text swaps in place, same layout); 4 is a text-transform removal — before/after is 'De Julio' → 'de julio' in the header line.
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Style
Bug Fixes