fix(test): dev tip typecheck break — singular classifyBareCampaign call sites - #2616
Merged
Conversation
The main→dev back-merge (db961c3) reconciled the naija/terere test onto dev's plural API but left two call sites on the removed singular name, breaking typecheck and the unit suite on every branch off dev.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
Code-analysis diffPainscore total: 7061.25 → 7061.25 (0) |
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The main→dev back-merge (db961c3) left two call sites in
campaign-maps.test.tson the removed singularclassifyBareCampaignAPI. Every branch offdevcurrently fails typecheck and the unit suite.Two-line fix: call
classifyBareCampaigns([c], …).Risks
None — test-only. Note #2613 rewrites this module and deletes the test block entirely; if it merges first, close this PR.
QA
tsc --noEmitexit 0;jest campaign-maps.test.ts52/52 passing.🤖 Generated with Claude Code