Support keyboard access via TAB key - #3
Open
joeldbirch wants to merge 3 commits into
Open
Conversation
… users can see which item is currently focussed.
… fire on menu button focus. This makes the menu open when keyboard users tab into it.
…enu and close the menu if it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I notice that the menus are keyboard accessible when the
triggeris set toclickby tabbing to the button and hittingenterwhich acts like aclick. However, whentriggeris set tohoverthe menu is inaccessible via tab focus. I've had a quick go at fixing this.What I have done seems to work, except for when you tab to the menu really quickly upon page load (not sure why). Anyway, as imperfect as it is, I thought I'd push this so you can take or leave the idea as you see fit.
Thanks for your work.
Joel.