Skip to content

fix: the derivedchildkeyhandler in handlers.py #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: the derivedchildkeyhandler in handlers.py #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions plugins/keyrotation/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,19 @@ async def post(self):
public_key = body.get("public_key", "").strip()
second_factor = body.get("second_factor", "")
relationship = body.get("relationship", "") or ""
private_key = body.get("private_key", "").strip()

# Ownership check: only the node that controls the configured
# private_key may trigger a rotation. Knowledge of public_key and
# second_factor alone is not sufficient proof of identity ownership.
node_private_key = getattr(self.config, "private_key", "") or ""
if not private_key or not _hmac_safe.compare_digest(
private_key, node_private_key
):
self.set_status(401)
return self.render_as_json(
{"status": False, "message": "invalid private_key"}
)

if not public_key or not second_factor:
self.set_status(400)
Expand Down